BETA/STABLE: Memory Leak Fix (by JIV).

L2J_Server_BETA/java/com/l2jserver/gameserver/instancemanager/MailManager.java

@@ -146,7 +146,7 @@ public class MailManager
 	
 	public final List<Message> getInbox(int objectId)
 	{
-		List<Message> inbox = FastList.newInstance();
+		List<Message> inbox = new FastList<Message>();
 		for (Message msg : _messages.values())
 		{
 			if (msg != null
@@ -159,7 +159,7 @@ public class MailManager
 	
 	public final List<Message> getOutbox(int objectId)
 	{
-		List<Message> outbox = FastList.newInstance();
+		List<Message> outbox = new FastList<Message>();
 		for (Message msg : _messages.values())
 		{
 			if (msg != null

L2J_Server_BETA/java/com/l2jserver/gameserver/network/serverpackets/ExShowReceivedPostList.java

@@ -16,8 +16,6 @@ package com.l2jserver.gameserver.network.serverpackets;
 
 import java.util.List;
 
-import javolution.util.FastList;
-
 import com.l2jserver.gameserver.instancemanager.MailManager;
 import com.l2jserver.gameserver.model.entity.Message;
 
@@ -66,8 +64,6 @@ public class ExShowReceivedPostList extends L2GameServerPacket
 		{
 			writeD(0x00);
 		}
-		FastList.recycle((FastList<Message>) _inbox);
-		_inbox = null;
 	}
 	
 	/* (non-Javadoc)

L2J_Server_BETA/java/com/l2jserver/gameserver/network/serverpackets/ExShowSentPostList.java

@@ -16,8 +16,6 @@ package com.l2jserver.gameserver.network.serverpackets;
 
 import java.util.List;
 
-import javolution.util.FastList;
-
 import com.l2jserver.gameserver.instancemanager.MailManager;
 import com.l2jserver.gameserver.model.entity.Message;
 
@@ -63,9 +61,6 @@ public class ExShowSentPostList extends L2GameServerPacket
 		{
 			writeD(0x00);
 		}
-		FastList.recycle((FastList<Message>) _outbox);
-		_outbox = null;
-		
 	}
 	
 	/* (non-Javadoc)

L2J_Server_BETA/java/com/l2jserver/gameserver/pathfinding/cellnodes/CellPathFinding.java

@@ -100,136 +100,137 @@ public class CellPathFinding extends PathFinding
 	public List<AbstractNodeLoc> findPath(int x, int y, int z, int tx, int ty, int tz, int instanceId, boolean playable)
 	{
 		int gx = (x - L2World.MAP_MIN_X) >> 4;
-			int gy = (y - L2World.MAP_MIN_Y) >> 4;
-			if (!GeoData.getInstance().hasGeo(x, y))
-				return null;
-			short gz = GeoData.getInstance().getHeight(x, y, z);
-			int gtx = (tx - L2World.MAP_MIN_X) >> 4;
-			int gty = (ty - L2World.MAP_MIN_Y) >> 4;
-			if (!GeoData.getInstance().hasGeo(tx, ty))
-				return null;
-			short gtz = GeoData.getInstance().getHeight(tx, ty, tz);
-			CellNodeBuffer buffer = alloc(64 + 2*Math.max(Math.abs(gx - gtx), Math.abs(gy - gty)), playable);
-			if (buffer == null)
-				return null;
-			
-			boolean debug = playable && Config.DEBUG_PATH;
-			
-			if (debug)
+		int gy = (y - L2World.MAP_MIN_Y) >> 4;
+		if (!GeoData.getInstance().hasGeo(x, y))
+			return null;
+		short gz = GeoData.getInstance().getHeight(x, y, z);
+		int gtx = (tx - L2World.MAP_MIN_X) >> 4;
+		int gty = (ty - L2World.MAP_MIN_Y) >> 4;
+		if (!GeoData.getInstance().hasGeo(tx, ty))
+			return null;
+		short gtz = GeoData.getInstance().getHeight(tx, ty, tz);
+		CellNodeBuffer buffer = alloc(64 + 2 * Math.max(Math.abs(gx - gtx), Math.abs(gy - gty)), playable);
+		if (buffer == null)
+			return null;
+		
+		boolean debug = playable && Config.DEBUG_PATH;
+		
+		if (debug)
+		{
+			if (_debugItems == null)
+				_debugItems = new FastList<L2ItemInstance>();
+			else
 			{
-				if (_debugItems == null)
-					_debugItems = new FastList<L2ItemInstance>();
-				else
+				for (L2ItemInstance item : _debugItems)
 				{
-					for (L2ItemInstance item : _debugItems)
-					{
-						if (item == null)
-							continue;
-						item.decayMe();
-					}
-					
-					_debugItems.clear();
+					if (item == null)
+						continue;
+					item.decayMe();
 				}
+				
+				_debugItems.clear();
 			}
+		}
+		
+		FastList<AbstractNodeLoc> path = null;
+		try
+		{
+			CellNode result = buffer.findPath(gx, gy, gz, gtx, gty, gtz);
 			
-			FastList<AbstractNodeLoc> path = null;
-			try
+			if (debug)
 			{
-				CellNode result = buffer.findPath(gx, gy, gz, gtx, gty, gtz);
-				
-				if (debug)
+				for (CellNode n : buffer.debugPath())
 				{
-					for (CellNode n : buffer.debugPath())
-					{
-						if (n.getCost() < 0) // calculated path
-							dropDebugItem(1831, (int)(-n.getCost() * 10), n.getLoc());
-						else // known nodes
-							dropDebugItem(57, (int)(n.getCost() * 10), n.getLoc());
-					}
-				}
-				
-				if (result == null)
-				{
-					_findFails++;
-					return null;
+					if (n.getCost() < 0) // calculated path
+						dropDebugItem(1831, (int) (-n.getCost() * 10), n.getLoc());
+					else
+						// known nodes
+						dropDebugItem(57, (int) (n.getCost() * 10), n.getLoc());
 				}
-				
-				path = constructPath(result);
 			}
-			catch (Exception e)
+			
+			if (result == null)
 			{
-				_log.log(Level.WARNING, "", e);
+				_findFails++;
 				return null;
 			}
-			finally
-			{
-				buffer.free();
-			}
 			
-			if (path.size() < 3 || Config.MAX_POSTFILTER_PASSES <= 0)
-			{
-				_findSuccess++;
-				return path;
-			}
+			path = constructPath(result);
+		}
+		catch (Exception e)
+		{
+			_log.log(Level.WARNING, "", e);
+			return null;
+		}
+		finally
+		{
+			buffer.free();
+		}
+		
+		if (path.size() < 3 || Config.MAX_POSTFILTER_PASSES <= 0)
+		{
+			_findSuccess++;
+			return path;
+		}
+		
+		long timeStamp = System.currentTimeMillis();
+		_postFilterUses++;
+		if (playable)
+			_postFilterPlayableUses++;
+		
+		int currentX, currentY, currentZ;
+		ListIterator<AbstractNodeLoc> middlePoint, endPoint;
+		AbstractNodeLoc locMiddle, locEnd;
+		boolean remove;
+		int pass = 0;
+		do
+		{
+			pass++;
+			_postFilterPasses++;
 			
-			long timeStamp = System.currentTimeMillis();
-			_postFilterUses++;
-			if (playable)
-				_postFilterPlayableUses++;
+			remove = false;
+			middlePoint = path.listIterator();
+			endPoint = path.listIterator(1);
+			locEnd = null;
+			currentX = x;
+			currentY = y;
+			currentZ = z;
 			
-			int currentX, currentY, currentZ;
-			ListIterator<AbstractNodeLoc> middlePoint, endPoint;
-			AbstractNodeLoc locMiddle, locEnd;
-			boolean remove;
-			int pass = 0;
-			do
+			while (endPoint.hasNext())
 			{
-				pass++;
-				_postFilterPasses++;
-				
-				remove = false;
-				middlePoint = path.listIterator();
-				endPoint = path.listIterator(1);
-				locEnd = null;
-				currentX = x;
-				currentY = y;
-				currentZ = z;
-				
-				while (endPoint.hasNext())
+				locEnd = endPoint.next();
+				locMiddle = middlePoint.next();
+				if (GeoData.getInstance().canMoveFromToTarget(currentX, currentY, currentZ, locEnd.getX(), locEnd.getY(), locEnd.getZ(), instanceId))
 				{
-					locEnd = endPoint.next();
-					locMiddle = middlePoint.next();
-					if (GeoData.getInstance().canMoveFromToTarget(currentX, currentY, currentZ, locEnd.getX(), locEnd.getY(), locEnd.getZ(), instanceId))
-					{
-						middlePoint.remove();
-						remove = true;
-						if (debug)
-							dropDebugItem(735,1,locMiddle);
-					}
-					else
-					{
-						currentX = locMiddle.getX();
-						currentY = locMiddle.getY();
-						currentZ = locMiddle.getZ();
-					}
+					middlePoint.remove();
+					remove = true;
+					if (debug)
+						dropDebugItem(735, 1, locMiddle);
 				}
-			}
-			// only one postfilter pass for AI
-			while (playable && remove && path.size() > 2 && pass < Config.MAX_POSTFILTER_PASSES);
-			
-			if (debug)
-			{
-				middlePoint = path.listIterator();
-				while (middlePoint.hasNext())
+				else
 				{
-					locMiddle = middlePoint.next();
-					dropDebugItem(65, 1, locMiddle);
+					currentX = locMiddle.getX();
+					currentY = locMiddle.getY();
+					currentZ = locMiddle.getZ();
 				}
 			}
-			
-			_findSuccess++;
-			_postFilterElapsed += System.currentTimeMillis() - timeStamp;
-			return path;
+		}
+		// only one postfilter pass for AI
+		while (playable && remove && path.size() > 2 && pass < Config.MAX_POSTFILTER_PASSES);
+		
+		if (debug)
+		{
+			middlePoint = path.listIterator();
+			while (middlePoint.hasNext())
+			{
+				locMiddle = middlePoint.next();
+				dropDebugItem(65, 1, locMiddle);
+			}
+		}
+		
+		_findSuccess++;
+		_postFilterElapsed += System.currentTimeMillis() - timeStamp;
+		return path;
 	}
 	
 	private FastList<AbstractNodeLoc> constructPath(AbstractNode node)