BETA: Code refactoring and new condition for Recipes item handler.

L2J_DataPack_BETA/data/scripts/handlers/itemhandlers/Recipes.java

@@ -24,80 +24,79 @@ import com.l2jserver.gameserver.network.SystemMessageId;
 import com.l2jserver.gameserver.network.serverpackets.SystemMessage;
 
 /**
- * This class ...
- *
- * @version $Revision: 1.1.2.5.2.5 $ $Date: 2005/04/06 16:13:51 $
+ * @author Zoey76
  */
-
 public class Recipes implements IItemHandler
 {
-	/**
-	 * 
-	 * @see com.l2jserver.gameserver.handler.IItemHandler#useItem(com.l2jserver.gameserver.model.actor.L2Playable, com.l2jserver.gameserver.model.L2ItemInstance, boolean)
-	 */
 	public void useItem(L2Playable playable, L2ItemInstance item, boolean forceUse)
 	{
 		if (!(playable instanceof L2PcInstance))
+		{
+			return;
+		}
+		final L2PcInstance activeChar = playable.getActingPlayer();
+		
+		if (activeChar.isInCraftMode())
+		{
+			activeChar.sendPacket(SystemMessageId.CANT_ALTER_RECIPEBOOK_WHILE_CRAFTING);
 			return;
-		L2PcInstance activeChar = (L2PcInstance) playable;
-		L2RecipeList rp = RecipeController.getInstance().getRecipeByItemId(item.getItemId());
+		}
+		
+		final L2RecipeList rp = RecipeController.getInstance().getRecipeByItemId(item.getItemId());
 		if (rp == null)
+		{
 			return;
+		}
+		
+		SystemMessage sm;
 		if (activeChar.hasRecipeList(rp.getId()))
-			activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.RECIPE_ALREADY_REGISTERED));
+		{
+			activeChar.sendPacket(SystemMessageId.RECIPE_ALREADY_REGISTERED);
+		}
 		else
 		{
-			if (rp.isDwarvenRecipe())
+			boolean canCraft = false;
+			boolean recipeLevel = false;
+			boolean recipeLimit = false;
+			if (rp.isDwarvenRecipe() && (canCraft = activeChar.hasDwarvenCraft()))
 			{
-				if (activeChar.hasDwarvenCraft())
+				if (recipeLevel = (rp.getLevel() > activeChar.getDwarvenCraft()))
 				{
-					if (rp.getLevel() > activeChar.getDwarvenCraft())
-					{
-						//can't add recipe, becouse create item level too low
-						activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.CREATE_LVL_TOO_LOW_TO_REGISTER));
-					}
-					else if (activeChar.getDwarvenRecipeBook().length >= activeChar.getDwarfRecipeLimit())
-					{
-						//Up to $s1 recipes can be registered.
-						SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.UP_TO_S1_RECIPES_CAN_REGISTER);
-						sm.addNumber(activeChar.getDwarfRecipeLimit());
-						activeChar.sendPacket(sm);
-					}
-					else
-					{
-						activeChar.registerDwarvenRecipeList(rp, true);
-						activeChar.destroyItem("Consume", item.getObjectId(), 1, null, false);
-						activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.S1_ADDED).addItemName(item));
-					}
+					recipeLimit = activeChar.getDwarvenRecipeBook().length >= activeChar.getDwarfRecipeLimit();
 				}
-				else
-					activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.CANT_REGISTER_NO_ABILITY_TO_CRAFT));
 			}
-			else
+			else if (canCraft = activeChar.hasCommonCraft())
 			{
-				if (activeChar.hasCommonCraft())
+				if (recipeLevel = (rp.getLevel() > activeChar.getCommonCraft()))
 				{
-					if (rp.getLevel() > activeChar.getCommonCraft())
-					{
-						//can't add recipe, becouse create item level too low
-						activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.CREATE_LVL_TOO_LOW_TO_REGISTER));
-					}
-					else if (activeChar.getCommonRecipeBook().length >= activeChar.getCommonRecipeLimit())
-					{
-						//Up to $s1 recipes can be registered.
-						SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.UP_TO_S1_RECIPES_CAN_REGISTER);
-						sm.addNumber(activeChar.getCommonRecipeLimit());
-						activeChar.sendPacket(sm);
-					}
-					else
-					{
-						activeChar.registerCommonRecipeList(rp, true);
-						activeChar.destroyItem("Consume", item.getObjectId(), 1, null, false);
-						activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.S1_ADDED).addItemName(item));
-					}
+					recipeLimit = activeChar.getCommonRecipeBook().length >= activeChar.getCommonRecipeLimit();
+				}
+			}
+			
+			if (canCraft)
+			{
+				if (recipeLevel)
+				{
+					activeChar.sendPacket(SystemMessageId.CREATE_LVL_TOO_LOW_TO_REGISTER);
+				}
+				else if (recipeLimit)
+				{
+					sm = SystemMessage.getSystemMessage(SystemMessageId.UP_TO_S1_RECIPES_CAN_REGISTER);
+					sm.addNumber(activeChar.getDwarfRecipeLimit());
+					activeChar.sendPacket(sm);
 				}
 				else
-					activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.CANT_REGISTER_NO_ABILITY_TO_CRAFT));
+				{
+					activeChar.registerDwarvenRecipeList(rp, true);
+					activeChar.destroyItem("Consume", item.getObjectId(), 1, null, false);
+					sm = SystemMessage.getSystemMessage(SystemMessageId.S1_ADDED);
+					sm.addItemName(item);
+					activeChar.sendPacket(sm);
+				}
+			}
+			else
+			{
+				activeChar.sendPacket(SystemMessageId.CANT_REGISTER_NO_ABILITY_TO_CRAFT);
 			}
 		}
 	}