瀏覽代碼

Remove "final" modifier from picocli option fields.

Fields for picocli options can not have the "final" modifier. The java
compiler might inline the values at compile time and loaded values from
the command line would not be used.
HorridoJoho 1 年之前
父節點
當前提交
b0da5b9715
共有 1 個文件被更改,包括 4 次插入4 次删除
  1. 4 4
      src/main/java/com/l2jserver/cli/command/BuildCommand.java

+ 4 - 4
src/main/java/com/l2jserver/cli/command/BuildCommand.java

@@ -47,23 +47,23 @@ public class BuildCommand extends AbstractCommand {
 		"--login-directory",
 		"-lsdir"
 	}, defaultValue = DEFAULT_LOGIN_SOURCE_DIR, description = "Login directory")
-	private final String loginDirectory = DEFAULT_LOGIN_SOURCE_DIR;
+	private String loginDirectory = DEFAULT_LOGIN_SOURCE_DIR;
 	@Option(names = {
 		"--game-directory",
 		"-gsdir"
 	}, defaultValue = DEFAULT_GAME_SOURCE_DIR, description = "Game directory")
-	private final String gameDirectory = DEFAULT_GAME_SOURCE_DIR;
+	private String gameDirectory = DEFAULT_GAME_SOURCE_DIR;
 	@Option(names = {
 		"--datapack-directory",
 		"-dpdir"
 	}, defaultValue = DEFAULT_DATAPACK_SOURCE_DIR, description = "DataPack directory")
-	private final String datapackDirectory = DEFAULT_DATAPACK_SOURCE_DIR;
+	private String datapackDirectory = DEFAULT_DATAPACK_SOURCE_DIR;
 	
 	@Option(names = {
 		"--skip-tests",
 		"-st"
 	}, defaultValue = "true", description = "Skip Tests")
-	private final boolean skipTests = true;
+	private boolean skipTests = true;
 	
 	@Override
 	public void run() {